mirror/miniaudio
1
0
Fork 0
mirror of https://github.com/mackron/miniaudio.git synced 2026-04-22 00:06:59 +02:00
Code Issues Packages Projects Releases Wiki Activity

DirectSound: Fix an error when stopping the device.

Browse Source 
If the capture side fails to stop it would result in the function
returning early thereby not giving the playback side a chance to also
stop which would result in a looping glitch.
This commit is contained in:
David Reid
2026-01-03 06:42:57 +10:00
parent 6048a9a73e
commit 3b2af39864
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
miniaudio.h
+7 -2
View File
@@ -26187,12 +26187,13 @@ static ma_result ma_device_stop__dsound(ma_device* pDevice)
{
ma_device_state_dsound* pDeviceStateDSound = ma_device_get_backend_state__dsound(pDevice);
HRESULT hr;
ma_bool32 wasSuccessful = MA_TRUE;
if (pDevice->type == ma_device_type_capture || pDevice->type == ma_device_type_duplex) {
hr = ma_IDirectSoundCaptureBuffer_Stop(pDeviceStateDSound->pCaptureBuffer);
if (FAILED(hr)) {
ma_log_post(ma_device_get_log(pDevice), MA_LOG_LEVEL_ERROR, "[DirectSound] IDirectSoundCaptureBuffer_Stop() failed.");
return ma_result_from_HRESULT(hr);
wasSuccessful = MA_FALSE;
}
}
@@ -26248,7 +26249,7 @@ static ma_result ma_device_stop__dsound(ma_device* pDevice)
hr = ma_IDirectSoundBuffer_Stop(pDeviceStateDSound->pPlaybackBuffer);
if (FAILED(hr)) {
ma_log_post(ma_device_get_log(pDevice), MA_LOG_LEVEL_ERROR, "[DirectSound] IDirectSoundBuffer_Stop() failed.");
return ma_result_from_HRESULT(hr);
wasSuccessful = MA_FALSE;
}
ma_IDirectSoundBuffer_SetCurrentPosition(pDeviceStateDSound->pPlaybackBuffer, 0);
@@ -26261,6 +26262,10 @@ static ma_result ma_device_stop__dsound(ma_device* pDevice)
pDeviceStateDSound->isPlaybackDeviceStarted = MA_FALSE;
}
if (!wasSuccessful) {
return MA_ERROR;
}
return MA_SUCCESS;
}