portersky/xone_macos
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: prefix private data members with m_

Browse Source 
Rename all trailing-underscore private data members to the m_ prefix
required by AGENTS.md, across the auth, crypto, gip, mt76, and usb
transport classes plus the app session classes. Pure rename; no
behavior change. Full build and test suite pass.

Co-Authored-By: qwen3.8-27b@q3_k_xl: renamed members to m_ prefix
This commit is contained in:
portersky
2026-08-29 14:36:28 +02:00
parent ae9c71d76e
commit dfe7e8b87d
12 changed files with 329 additions and 329 deletions
Download Patch File Download Diff File Expand all files Collapse all files
include/gip/protocol.hpp
+29 -29
View File
@@ -164,11 +164,11 @@ class client : public xone::auth::auth_sink {
public:
client(adapter& adapter, u8 id);
auto id() const -> u8 { return id_; }
auto hardware() const -> gip_hardware const& { return hardware_; }
auto audio_config_in() const -> gip_audio_config const& { return audio_config_in_; }
auto audio_config_out() const -> gip_audio_config const& { return audio_config_out_; }
auto classes() const -> std::vector<std::string> const& { return classes_; }
auto id() const -> u8 { return m_id; }
auto hardware() const -> gip_hardware const& { return m_hardware; }
auto audio_config_in() const -> gip_audio_config const& { return m_audio_config_in; }
auto audio_config_out() const -> gip_audio_config const& { return m_audio_config_out; }
auto classes() const -> std::vector<std::string> const& { return m_classes; }
auto has_interface(xone::guid_t const& guid) const -> bool;
@@ -187,35 +187,35 @@ public:
auto send(std::span<u8 const> pkt, bool acknowledge) -> int override;
auto set_encryption_key(std::span<u8 const> key) -> int override;
auto start_auth() -> int { return auth_.start(); }
auto start_auth() -> int { return m_auth.start(); }
auto process_auth(std::span<u8 const> data) -> int
{
return auth_.process_pkt(data);
return m_auth.process_pkt(data);
}
private:
friend class adapter;
adapter& adapter_;
u8 id_;
gip_hardware hardware_{};
adapter& m_adapter;
u8 m_id;
gip_hardware m_hardware{};
struct info_element {
u8 count = 0;
std::vector<u8> data;
};
std::unique_ptr<info_element> client_commands_;
std::unique_ptr<info_element> firmware_versions_;
std::unique_ptr<info_element> audio_formats_;
std::unique_ptr<info_element> capabilities_out_;
std::unique_ptr<info_element> capabilities_in_;
std::vector<std::string> classes_;
std::unique_ptr<info_element> interfaces_;
std::unique_ptr<info_element> hid_descriptor_;
std::unique_ptr<info_element> m_client_commands;
std::unique_ptr<info_element> m_firmware_versions;
std::unique_ptr<info_element> m_audio_formats;
std::unique_ptr<info_element> m_capabilities_out;
std::unique_ptr<info_element> m_capabilities_in;
std::vector<std::string> m_classes;
std::unique_ptr<info_element> m_interfaces;
std::unique_ptr<info_element> m_hid_descriptor;
gip_audio_config audio_config_in_;
gip_audio_config audio_config_out_;
gip_audio_config m_audio_config_in;
gip_audio_config m_audio_config_out;
// Chunk reassembly buffers (large packets are split into chunks).
struct chunk_buffer {
@@ -223,10 +223,10 @@ private:
u32 length = 0;
std::vector<u8> data;
};
std::unique_ptr<chunk_buffer> chunk_buf_out_;
std::unique_ptr<chunk_buffer> chunk_buf_in_;
std::unique_ptr<chunk_buffer> m_chunk_buf_out;
std::unique_ptr<chunk_buffer> m_chunk_buf_in;
xone::auth::auth auth_{*this};
xone::auth::auth m_auth{*this};
};
class adapter {
@@ -288,13 +288,13 @@ private:
auto parse_hid_descriptor(client& c, u16 const offsets[8],
std::span<u8 const> data) -> int;
transport& transport_;
client_listener& listener_;
int audio_packet_count_;
transport& m_transport;
client_listener& m_listener;
int m_audio_packet_count;
std::array<std::unique_ptr<client>, k_max_clients> clients_;
u8 data_sequence_ = 0;
u8 audio_sequence_ = 0;
std::array<std::unique_ptr<client>, k_max_clients> m_clients;
u8 m_data_sequence = 0;
u8 m_audio_sequence = 0;
};
} // namespace xone::gip