mirror/miniaudio
1
0
Fork 0
mirror of https://github.com/mackron/miniaudio.git synced 2026-04-21 15:56:58 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix a bug when reading from a node with no attachments.

Browse Source 
This would try reading from an uninitialized buffer thereby resulting
in a bad audio glitch. This does two things to fix the problem:

  1) When there are no input nodes attached to an input bus, nothing is
     read and 0 will be returned for the frames read variable.

  2) The buffer is silenced by default.

This fixes a bug with ma_engine where it would glitch in the moment
just after the engine is initialized and before a sound or group is
attached.
This commit is contained in:
David Reid
2021-01-13 22:03:09 +10:00
parent 14c5b35b8a
commit fa416d323b
2 changed files with 38 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
research/miniaudio_routing.c
+5 -5
View File
@@ -89,11 +89,11 @@ int main(int argc, char** argv)
return -1;
}
ma_node_set_state_time(&g_dataSourceNode, ma_node_state_started, 48000*1);
ma_node_set_state_time(&g_dataSourceNode, ma_node_state_stopped, 48000*5);
/*ma_node_set_state_time(&g_dataSourceNode, ma_node_state_started, 48000*1);
ma_node_set_state_time(&g_dataSourceNode, ma_node_state_stopped, 48000*5);*/
#if 0
/*
Splitter node. Note that we've already attached the data source node to another, so this section
will test that changing of attachments works as expected.
@@ -141,12 +141,12 @@ int main(int argc, char** argv)
ma_node_attach_output_bus(&g_splitterNode, 1, &g_loopNode, 1);
/* Now loop back to the splitter node to form a loop. */
ma_node_attach_output_bus(&g_loopNode, 1, &g_splitterNode, 0);
/*ma_node_attach_output_bus(&g_loopNode, 1, &g_splitterNode, 0);*/
#endif
/* The data source needs to have it's connection changed from the endpoint to the splitter. */
ma_node_attach_output_bus(&g_dataSourceNode, 0, &g_splitterNode, 0);
#endif