From eef66940c2c31770f3ef84e4de278f28eb206a58 Mon Sep 17 00:00:00 2001 From: David Reid Date: Sun, 21 Mar 2021 08:07:26 +1000 Subject: [PATCH] Fix a bug when calculating buffer sizes. This fixes the following APIs: * ma_calculate_buffer_size_in_milliseconds_from_frames() * ma_calculate_buffer_size_in_frames_from_milliseconds() Public issue https://github.com/mackron/miniaudio/issues/283 --- miniaudio.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/miniaudio.h b/miniaudio.h index 799b2f78..af4ca0e9 100644 --- a/miniaudio.h +++ b/miniaudio.h @@ -33576,7 +33576,7 @@ MA_API ma_uint32 ma_calculate_buffer_size_in_milliseconds_from_frames(ma_uint32 return 0; } - return bufferSizeInFrames / (sampleRate/1000); + return bufferSizeInFrames*1000 / sampleRate; } MA_API ma_uint32 ma_calculate_buffer_size_in_frames_from_milliseconds(ma_uint32 bufferSizeInMilliseconds, ma_uint32 sampleRate) @@ -33586,7 +33586,7 @@ MA_API ma_uint32 ma_calculate_buffer_size_in_frames_from_milliseconds(ma_uint32 return 0; } - return bufferSizeInMilliseconds * (sampleRate/1000); + return bufferSizeInMilliseconds*sampleRate / 1000; } MA_API void ma_copy_pcm_frames(void* dst, const void* src, ma_uint64 frameCount, ma_format format, ma_uint32 channels) @@ -64534,9 +64534,9 @@ v0.10.33 - TBD - Core Audio: Fix a memory leak. - Core Audio: Fix a bug where the performance profile is not being used by playback devices. - JACK: Fix loading of 64-bit JACK on Windows. - - Add a safety check to the following APIs to prevent a division by zero: + - Fix a calculation error and add a safety check to the following APIs to prevent a division by zero: - ma_calculate_buffer_size_in_milliseconds_from_frames() - - ma_calculate_buffer_size_in_milliseconds_from_milliseconds() + - ma_calculate_buffer_size_in_frames_from_milliseconds() - Fix compilation errors relating to c89atomic. v0.10.32 - 2021-02-23