mirror/miniaudio
1
0
Fork 0
mirror of https://github.com/mackron/miniaudio.git synced 2026-04-21 15:56:58 +02:00
Code Issues Packages Projects Releases Wiki Activity

Remove a TODO.

Browse Source 
I tried addressing this, but upon doing so the build was slower. It was
especially bad with Clang where is was 2x slower(!), and just slightly
slower with GCC.

Not sure exactly what's going on here, but I guess the compiler is
hitting some edge case that's prevent efficient optimization. What's
weirder, is the slowness only affects the mono s16 code path. Other
code paths are totally fine.
This commit is contained in:
David Reid
2026-02-13 20:54:38 +10:00
parent 9d0f4a4103
commit b3340e629a
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
miniaudio.h
+7 -7
View File
@@ -59939,7 +59939,7 @@ static MA_INLINE void ma_linear_resampler_filter_s16(ma_linear_resampler* pResam
{ {
ma_int32* pLPF; ma_int32* pLPF;
ma_uint32 iLPF; ma_uint32 iLPF;
ma_uint32 lpfCount = pResampler->lpfOrder >> 1; /* TODO: It's actually more useful to store lpfCount instead of lpfOrder. */ ma_uint32 lpfCount = pResampler->lpfOrder >> 1;
ma_uint32 iChannel; ma_uint32 iChannel;
pLPF = MA_LINEAR_RESAMPLER_GET_LPF_STATE_S32(pResampler, 0); pLPF = MA_LINEAR_RESAMPLER_GET_LPF_STATE_S32(pResampler, 0);
@@ -59993,7 +59993,7 @@ static MA_INLINE void ma_linear_resampler_filter_s32(ma_linear_resampler* pResam
{ {
ma_int32* pLPF; ma_int32* pLPF;
ma_uint32 iLPF; ma_uint32 iLPF;
ma_uint32 lpfCount = pResampler->lpfOrder >> 1; /* TODO: It's actually more useful to store lpfCount instead of lpfOrder. */ ma_uint32 lpfCount = pResampler->lpfOrder >> 1;
ma_uint32 iChannel; ma_uint32 iChannel;
pLPF = MA_LINEAR_RESAMPLER_GET_LPF_STATE_S32(pResampler, 0); pLPF = MA_LINEAR_RESAMPLER_GET_LPF_STATE_S32(pResampler, 0);
@@ -60029,7 +60029,7 @@ static MA_INLINE void ma_linear_resampler_filter_s32_mono(ma_linear_resampler* p
{ {
ma_int32* pLPF; ma_int32* pLPF;
ma_uint32 iLPF; ma_uint32 iLPF;
ma_uint32 lpfCount = pResampler->lpfOrder >> 1; /* TODO: It's actually more useful to store lpfCount instead of lpfOrder. */ ma_uint32 lpfCount = pResampler->lpfOrder >> 1;
ma_uint32 iChannel; ma_uint32 iChannel;
pLPF = MA_LINEAR_RESAMPLER_GET_LPF_STATE_S32(pResampler, 0); pLPF = MA_LINEAR_RESAMPLER_GET_LPF_STATE_S32(pResampler, 0);
@@ -60065,7 +60065,7 @@ static MA_INLINE void ma_linear_resampler_filter_s32_stereo(ma_linear_resampler*
{ {
ma_int32* pLPF; ma_int32* pLPF;
ma_uint32 iLPF; ma_uint32 iLPF;
ma_uint32 lpfCount = pResampler->lpfOrder >> 1; /* TODO: It's actually more useful to store lpfCount instead of lpfOrder. */ ma_uint32 lpfCount = pResampler->lpfOrder >> 1;
ma_uint32 iChannel; ma_uint32 iChannel;
pLPF = MA_LINEAR_RESAMPLER_GET_LPF_STATE_S32(pResampler, 0); pLPF = MA_LINEAR_RESAMPLER_GET_LPF_STATE_S32(pResampler, 0);
@@ -60125,7 +60125,7 @@ static MA_INLINE void ma_linear_resampler_filter_f32(ma_linear_resampler* pResam
{ {
float* pLPF; float* pLPF;
ma_uint32 iLPF; ma_uint32 iLPF;
ma_uint32 lpfCount = pResampler->lpfOrder >> 1; /* TODO: It's actually more useful to store lpfCount instead of lpfOrder. */ ma_uint32 lpfCount = pResampler->lpfOrder >> 1;
ma_uint32 iChannel; ma_uint32 iChannel;
pLPF = MA_LINEAR_RESAMPLER_GET_LPF_STATE_F32(pResampler, 0); pLPF = MA_LINEAR_RESAMPLER_GET_LPF_STATE_F32(pResampler, 0);
@@ -60161,7 +60161,7 @@ static MA_INLINE void ma_linear_resampler_filter_f32_mono(ma_linear_resampler* p
{ {
float* pLPF; float* pLPF;
ma_uint32 iLPF; ma_uint32 iLPF;
ma_uint32 lpfCount = pResampler->lpfOrder >> 1; /* TODO: It's actually more useful to store lpfCount instead of lpfOrder. */ ma_uint32 lpfCount = pResampler->lpfOrder >> 1;
ma_uint32 iChannel; ma_uint32 iChannel;
pLPF = MA_LINEAR_RESAMPLER_GET_LPF_STATE_F32(pResampler, 0); pLPF = MA_LINEAR_RESAMPLER_GET_LPF_STATE_F32(pResampler, 0);
@@ -60197,7 +60197,7 @@ static MA_INLINE void ma_linear_resampler_filter_f32_stereo(ma_linear_resampler*
{ {
float* pLPF; float* pLPF;
ma_uint32 iLPF; ma_uint32 iLPF;
ma_uint32 lpfCount = pResampler->lpfOrder >> 1; /* TODO: It's actually more useful to store lpfCount instead of lpfOrder. */ ma_uint32 lpfCount = pResampler->lpfOrder >> 1;
ma_uint32 iChannel; ma_uint32 iChannel;
pLPF = MA_LINEAR_RESAMPLER_GET_LPF_STATE_F32(pResampler, 0); pLPF = MA_LINEAR_RESAMPLER_GET_LPF_STATE_F32(pResampler, 0);