mirror/miniaudio
1
0
Fork 0
mirror of https://github.com/mackron/miniaudio.git synced 2026-04-22 08:14:04 +02:00
Code Issues Packages Projects Releases Wiki Activity

DirectSound: Revert an earlier commit.

Browse Source 
The change this commit is reverting causes glitching with smaller
buffers for some reason. More investigation into this is required.
This commit is contained in:
David Reid
2019-03-05 17:27:49 +10:00
parent e0c7af2966
commit 10f13312bf
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mini_al.h
+1 -5
View File
@@ -9547,13 +9547,9 @@ mal_result mal_device_main_loop__dsound(mal_device* pDevice)
/* /*
We may need to start the device. We want two full periods to be written before starting the playback device. Having an extra period adds We may need to start the device. We want two full periods to be written before starting the playback device. Having an extra period adds
a bit of a buffer to prevent the playback buffer from getting starved. a bit of a buffer to prevent the playback buffer from getting starved.
UPDATE: After testing, it looks like something weird is going on where it's as if waiting for two periods instead of one is too late and
instead we should wait until only a single period is written. I don't fully understand why this is happening, but since switching it to
one period instead of two makes it consistent with WASAPI I'm going to go ahead with that.
*/ */
framesWrittenToPlaybackDevice += framesWrittenThisIteration; framesWrittenToPlaybackDevice += framesWrittenThisIteration;
if (!isPlaybackDeviceStarted && framesWrittenToPlaybackDevice >= ((pDevice->playback.internalBufferSizeInFrames/pDevice->playback.internalPeriods)*1)) { if (!isPlaybackDeviceStarted && framesWrittenToPlaybackDevice >= ((pDevice->playback.internalBufferSizeInFrames/pDevice->playback.internalPeriods)*2)) {
if (FAILED(mal_IDirectSoundBuffer_Play((mal_IDirectSoundBuffer*)pDevice->dsound.pPlaybackBuffer, 0, 0, MAL_DSBPLAY_LOOPING))) { if (FAILED(mal_IDirectSoundBuffer_Play((mal_IDirectSoundBuffer*)pDevice->dsound.pPlaybackBuffer, 0, 0, MAL_DSBPLAY_LOOPING))) {
mal_IDirectSoundCaptureBuffer_Stop((mal_IDirectSoundCaptureBuffer*)pDevice->dsound.pCaptureBuffer); mal_IDirectSoundCaptureBuffer_Stop((mal_IDirectSoundCaptureBuffer*)pDevice->dsound.pCaptureBuffer);
return mal_post_error(pDevice, MAL_LOG_LEVEL_ERROR, "[DirectSound] IDirectSoundBuffer_Play() failed.", MAL_FAILED_TO_START_BACKEND_DEVICE); return mal_post_error(pDevice, MAL_LOG_LEVEL_ERROR, "[DirectSound] IDirectSoundBuffer_Play() failed.", MAL_FAILED_TO_START_BACKEND_DEVICE);